Dedimania not storing "slow" drivers

Discuss everything about Xymph's Aseco flavoured server control scripts for TM Forever / classic TMN and for TM² Canyon.

Moderators: Xymph, TM-Patrol

nouseforname
swift roadking
swift roadking
Posts: 840
Joined: 20 Apr 2008 08:58
Owned TM-games: TMUF,TMNF, TMN
Manialink(s): therookies
Location: Germany
Contact:

Re: Dedimania not storing "slow" drivers

Post by nouseforname » 06 Feb 2009 09:21

Xymph wrote: You need to provide the context where this message appears.
Also, in plugin.dedimania.php set $dedi_debug to 2, see if it happens again, and provide the whole startup log.
wrote u a pm with the log.
Owner of the Rookie servers and some more. :)
Rookies HP
My Project
Rookies Manialinkcolor>

Xymph
Pit Crew
Pit Crew
Posts: 5708
Joined: 19 Aug 2007 12:58
Owned TM-games: TMN, TMU, TMF, TM²
Contact:

Re: Dedimania not storing "slow" drivers

Post by Xymph » 06 Feb 2009 09:22

w1lla wrote:Well the thing lvlao runs is aseco/rasp version of dedimania. I was the one who built it with calsmurf. He stopped developing but i want to continue. I can confirm it has parts of xaseco's dedimania plugin.
I'm sorry but I don't care, having "parts" means it is missing other pieces that are necessary for v1.05. I can't (and don't have time to) debug code that I didn't write myself.
Developer of XASECO for TMF/TMN ESWC & XASECO2 for TM²: see XAseco.org
Find your way around the Mania community from the TMN ESWC hub, TMF hub, TM² hub, and SM hub

User avatar
w1lla
TM-Patrol
TM-Patrol
Posts: 1466
Joined: 23 May 2007 07:20
Owned TM-games: TMU, TMN, TMF
Manialink(s): intr
Location: Venray

Re: Dedimania not storing "slow" drivers

Post by w1lla » 06 Feb 2009 09:38

i will have the time. The problem is that the new functions of dedimania are needed to be included to the dedimania plugin of a/r. I know what the problems are of dedimania as i got a pm of Slig. There will be a new version of dedimania for a/r out. Just have to wait. I can promise that the new one will come out this weekend or next week.

Code: Select all

tmnforever is nations and united makes it special. tmnforever has united. I need united!

User avatar
Slig
Pit Crew
Pit Crew
Posts: 2124
Joined: 05 Sep 2005 17:51
Owned TM-games: ALL
Location: TraxicoLand (Fr)
Contact:

Re: Dedimania not storing "slow" drivers

Post by Slig » 06 Feb 2009 10:10

Xymph wrote:You mean v1.05, I hope. :wink:
No, 1.04. The 1.05 does not exit in the tool list in the database, are you sur that you updated the version number ? :P

User avatar
lvlao
road tourist
road tourist
Posts: 82
Joined: 16 Oct 2006 12:47
Owned TM-games: TMO TMN TMNF TMUF
Contact:

Re: Dedimania not storing "slow" drivers

Post by lvlao » 06 Feb 2009 10:21

w1lla wrote:i will have the time. The problem is that the new functions of dedimania are needed to be included to the dedimania plugin of a/r. I know what the problems are of dedimania as i got a pm of Slig. There will be a new version of dedimania for a/r out. Just have to wait. I can promise that the new one will come out this weekend or next week.

WoW Thanks! :thumbsup:

I'll wait, no hurry, i'ts a game!

;)
TrackMania Nations Forever (Free Game): Mecha:Getter
Team --> Mecha:Team (Forum)
Server TM1 Stadium --> Mecha:Base tmtp://#join=lvlao_server
Server TM2 Stadium --> Mecha:Base² maniaplanet://#join=mecha@TMStadium

Xymph
Pit Crew
Pit Crew
Posts: 5708
Joined: 19 Aug 2007 12:58
Owned TM-games: TMN, TMU, TMF, TM²
Contact:

Re: Dedimania not storing "slow" drivers

Post by Xymph » 06 Feb 2009 15:09

Slig wrote:
Xymph wrote:You mean v1.05, I hope. :wink:
No, 1.04. The 1.05 does not exit in the tool list in the database, are you sur that you updated the version number ? :P
Uhm, very sure. I forgot that once for an hour after an earlier release, and it's not the kind of mistake I repeat. :P
Developer of XASECO for TMF/TMN ESWC & XASECO2 for TM²: see XAseco.org
Find your way around the Mania community from the TMN ESWC hub, TMF hub, TM² hub, and SM hub

User avatar
w1lla
TM-Patrol
TM-Patrol
Posts: 1466
Joined: 23 May 2007 07:20
Owned TM-games: TMU, TMN, TMF
Manialink(s): intr
Location: Venray

Re: Dedimania not storing "slow" drivers

Post by w1lla » 06 Feb 2009 15:31

Code: Select all

[errors] => Warning in method_helper.php(1008): Ignore record for dccw1lla : last check is different than best !
Warning in method_helper.php(1046): Ignore record for  : low limit is 6s ! (0)
Is the error i get. not With Xaseco ;).

What is the problem??!!

Code: Select all

tmnforever is nations and united makes it special. tmnforever has united. I need united!

User avatar
Slig
Pit Crew
Pit Crew
Posts: 2124
Joined: 05 Sep 2005 17:51
Owned TM-games: ALL
Location: TraxicoLand (Fr)
Contact:

Re: Dedimania not storing "slow" drivers

Post by Slig » 06 Feb 2009 17:05

w1lla wrote:

Code: Select all

[errors] => Warning in method_helper.php(1008): Ignore record for dccw1lla : last check is different than best !
Warning in method_helper.php(1046): Ignore record for  : low limit is 6s ! (0)
Is the error i get. not With Xaseco ;).
What is the problem??!!
The first one means that you sent inconsistent datas : the last cp time is not the same as the best time. I have added in the message the best and checkpoints times now, btw your script sent values, and so should know it.
The 2nd message should not be here and was caused by the first (i just have corrected it so it should not happen any more in such case)

[db@]Metzger
pedestrian
pedestrian
Posts: 13
Joined: 25 Jul 2007 11:38
Owned TM-games: TMO, TMS, TMNf, TMUf
Location: Altdorf near Nuremberg / Germany
Contact:

Re: Dedimania not storing "slow" drivers

Post by [db@]Metzger » 12 Feb 2009 07:34

We have dedimania problems on our servers too.

The first time we registered ist was in XASECO 1.04
Now we updated our Servers to XASECO 1.05 but the problem is the same :(
We deactivated the ckeckpoint tests like that:

Code: Select all

// $checkpoint_tests = true;  // now commence cheat tests
I'll try do explain the problem here with other words:

I join one of our Servers and there is a track with 10 local and the same dedimania Records. I have no dedimania rec.
The worst dedimania time is 15 seconds slower than the best for this track.
Now I'll drive a round and at the finish my time is worser than the worsest before.
The serverchat tells me that I've driven the 11th local record, but no line about a dedimania record.

We use XASECO 1.05 with activated (in vanilla these plugins are deactivated):
plugin.donate.php
plugin.autotime.php

and these other plugins:
plugin.fufi.menu.php
plugin.fufi.widgets.php
plugin.tmxinfo.php
plugin.forceMods.php

If you're interested in testing or to be explained on one of our servers please send me a pm

The problem and possible reason why the bug isn't detected yet may be, that you can only see it when you add a new track with no or only <30 dedimania records to your server and you drive the worsest time.

Xymph
Pit Crew
Pit Crew
Posts: 5708
Joined: 19 Aug 2007 12:58
Owned TM-games: TMN, TMU, TMF, TM²
Contact:

Re: Dedimania not storing "slow" drivers

Post by Xymph » 16 Feb 2009 19:45

[db@]Metzger wrote:We have dedimania problems on our servers too.
[...]
If you're interested in testing or to be explained on one of our servers please send me a pm

The problem and possible reason why the bug isn't detected yet may be, that you can only see it when you add a new track with no or only <30 dedimania records to your server and you drive the worsest time.
Metzger, does this problem still occur after using the latest plugin versions? What about you lille79, is your Dedi problem solved?
Developer of XASECO for TMF/TMN ESWC & XASECO2 for TM²: see XAseco.org
Find your way around the Mania community from the TMN ESWC hub, TMF hub, TM² hub, and SM hub

User avatar
lille79
Pit Crew
Pit Crew
Posts: 881
Joined: 09 Dec 2007 15:04
Owned TM-games: TMN, TMNF, TMUF
Location: Norway
Contact:

Re: Dedimania not storing "slow" drivers

Post by lille79 » 17 Feb 2009 11:31

Sorry but I haven't gotten around to testing your suggestions Xymph. Will try to do some testing today. My mind has been a little preoccupied...
/lille79
Old man of the Norwegian Trackmania team Super Sheep Racing
To visit my homepage/blog, and download the usbTMFserver, this is the place to go.

Xymph
Pit Crew
Pit Crew
Posts: 5708
Joined: 19 Aug 2007 12:58
Owned TM-games: TMN, TMU, TMF, TM²
Contact:

Re: Dedimania not storing "slow" drivers

Post by Xymph » 21 Feb 2009 18:10

With lille79's help in additional logging and testing, I tracked down and solved this problem. It was a bug in the plugin, caused by the introduction of the /dedicps feature in v0.98, so it's remarkable that it took so long before someone noticed and reported it. :shock:

The cause was /dedicps by default putting the last Dedimania record into a player data structure as "best run" reference for successive player runs. The plugin compares the current finish time with that best one, and discarded the finish quickly if the time was worse. This optimization should however not be applied if the current number of Dedi records is less than the maximum, because then even a worse time is still a new record.

So in plugin.dedimania.php edit function dedimania_playerfinish to add the line starting with "count" to this "if" statement:

Code: Select all

  // if not best/equal run on this track so far, bail out unless Laps mode
  // or less than MaxRecords records available
  if ($aseco->server->gameinfo->mode != 3 &&
      count($dedi_db['Challenge']['Records']) >= $dedi_db['MaxRecords'] &&
      (!isset($checkpoints[$login]) ||
       $checkpoints[$login]->curr_fin > $checkpoints[$login]->best_fin))
    return;
You can also get the fixed plugin from this download. I still need to look into two other things but then I'll be able to release v1.05b with all the recent fixes.
Developer of XASECO for TMF/TMN ESWC & XASECO2 for TM²: see XAseco.org
Find your way around the Mania community from the TMN ESWC hub, TMF hub, TM² hub, and SM hub

[db@]Metzger
pedestrian
pedestrian
Posts: 13
Joined: 25 Jul 2007 11:38
Owned TM-games: TMO, TMS, TMNf, TMUf
Location: Altdorf near Nuremberg / Germany
Contact:

Re: Dedimania not storing "slow" drivers

Post by [db@]Metzger » 23 Feb 2009 17:56

Xymph wrote:With lille79's help in additional logging and testing, I tracked down and solved this problem. It was a bug in the plugin, caused by the introduction of the /dedicps feature in v0.98, so it's remarkable that it took so long before someone noticed and reported it. :shock:

The cause was /dedicps by default putting the last Dedimania record into a player data structure as "best run" reference for successive player runs. The plugin compares the current finish time with that best one, and discarded the finish quickly if the time was worse. This optimization should however not be applied if the current number of Dedi records is less than the maximum, because then even a worse time is still a new record.

So in plugin.dedimania.php edit function dedimania_playerfinish to add the line starting with "count" to this "if" statement:

Code: Select all

  // if not best/equal run on this track so far, bail out unless Laps mode
  // or less than MaxRecords records available
  if ($aseco->server->gameinfo->mode != 3 &&
      count($dedi_db['Challenge']['Records']) >= $dedi_db['MaxRecords'] &&
      (!isset($checkpoints[$login]) ||
       $checkpoints[$login]->curr_fin > $checkpoints[$login]->best_fin))
    return;
You can also get the fixed plugin from this download. I still need to look into two other things but then I'll be able to release v1.05b with all the recent fixes.
Sorry Xymph, it doesn't work for me.
There is still no new Dedimania record counted (I tested it on a Track with only one Dediomania record).
I replaced the three php-files of your Zip-File.
Then I deactivated the checkpoint_tests like this

Code: Select all

  // $checkpoint_tests = true;  // now commence cheat tests
but the same bug still exists :(

Maybe the problem is, that there is only one Dedimania record... :(

Xymph
Pit Crew
Pit Crew
Posts: 5708
Joined: 19 Aug 2007 12:58
Owned TM-games: TMN, TMU, TMF, TM²
Contact:

Re: Dedimania not storing "slow" drivers

Post by Xymph » 23 Feb 2009 18:01

[db@]Metzger wrote:Maybe the problem is, that there is only one Dedimania record... :(
Not sure what you mean there, but I can only look into it if you PM me a link to a zipped logfile.txt with $dedi_debug = 4 that demonstrates your problem.
Developer of XASECO for TMF/TMN ESWC & XASECO2 for TM²: see XAseco.org
Find your way around the Mania community from the TMN ESWC hub, TMF hub, TM² hub, and SM hub

User avatar
lille79
Pit Crew
Pit Crew
Posts: 881
Joined: 09 Dec 2007 15:04
Owned TM-games: TMN, TMNF, TMUF
Location: Norway
Contact:

Re: Dedimania not storing "slow" drivers

Post by lille79 » 24 Feb 2009 16:12

[db@]Metzger wrote:Sorry Xymph, it doesn't work for me.
There is still no new Dedimania record counted (I tested it on a Track with only one Dediomania record).
I replaced the three php-files of your Zip-File.
Then I deactivated the checkpoint_tests like this

Code: Select all

  // $checkpoint_tests = true;  // now commence cheat tests
but the same bug still exists :(

Maybe the problem is, that there is only one Dedimania record... :(
I'm no expert, but if you have downloaded the new files, why are you disabling the checkpoint tests? Should work without doing that I think.
/lille79
Old man of the Norwegian Trackmania team Super Sheep Racing
To visit my homepage/blog, and download the usbTMFserver, this is the place to go.

Post Reply